Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all symbols #104

Closed
chrisleekr opened this issue Apr 19, 2021 · 2 comments · Fixed by #77
Closed

Support all symbols #104

chrisleekr opened this issue Apr 19, 2021 · 2 comments · Fixed by #77
Labels
enhancement New feature or request

Comments

@chrisleekr
Copy link
Owner

chrisleekr commented Apr 19, 2021

Is your proposal related to a problem?

No, just improvement.

Describe the solution you'd like

The bot is currently only providing FIAT to trade. However, the bot itself can trade different pairs such as BTCBNB/XRPBNB.
The only issue with this feature is setting Max Purchase Amount. For convenience, the bot was simply setting 100 for the Max Purchase Amount. It is working for FIATs; however, it does not work for other pairs.

I did a bit of research and found each symbol has filters called MIN_NOTIONAL, which specifies the minimum order amount. Below is the example of XRPBNB.

{
    "filterType": "MIN_NOTIONAL",
    "minNotional": "0.10000000",
    "applyToMarket": true,
    "avgPriceMins": 5
}

I think the following changes can make this feature working.

  1. Remove Max Purchase Amount from the global configuration.
  2. When adding new coin pair, dynamically calculate Max Purchase Amount based on the minimum notional.
    • i.e. XRPBNB minimum notional (0.1) * 10 = max purchase amount (1)
    • i.e. BNBBTC minimum notional (0.0001) * 10 = max purchase amount (0.001)
    • i.e. BNBUSDT minimum notional (10) * 10 = max purchase amount (100)
  3. If the trader wants to increase max purchase amount, then customise the symbol configuration.

Describe alternatives you've considered

Just keep trading with FIATs only.

Additional context

N/A

@chrisleekr chrisleekr added the enhancement New feature or request label Apr 19, 2021
@chrisleekr chrisleekr changed the title Feature: Support all pairs Feature: Support all coin pairs Apr 19, 2021
@chrisleekr chrisleekr changed the title Feature: Support all coin pairs Support all coin pairs Apr 19, 2021
@chrisleekr chrisleekr changed the title Support all coin pairs Support all symbols Apr 19, 2021
@dodavies
Copy link

dodavies commented May 5, 2021

will this allow adding alternate pairs.
I want to track doge/btc

@chrisleekr
Copy link
Owner Author

chrisleekr commented May 6, 2021

Hey @dodavies
It does already with the PR #77
Take a look. Note that the PR is still in development/stablising.

chrisleekr added a commit that referenced this issue May 21, 2021
…ements (#77)

- Updated frontend to display version - #59
- Support monitoring multiple coins simultaneously - #77
- Added docker-stack.yml for the Portainer - @hipposen
- Fixed precision issues for some FIAT - #90
- Improved frontend & settings UI - #93 #85
- Support all symbols - #104
- Added stop loss feature - #99
- Stabilised Local Tunnel, cronjob and Binance WebSocket
- Prevented to place new order when the API limit reached - #163
- Added NPM task for building docker image on Windows by @garyng - #175

Co-authored-by: GaryNg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants