Use finally for waiter.endAsync
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shouldn't change the semantics at all; it's just a nice win for the clarity and maintainability of the code, and it guarantees that even if we change it (e.g. to re-`throw`) in the future, it will always end the test waiter.
scalvert
approved these changes
Feb 24, 2022
|
TS stuff is independent so I'm merging over it and resolving that in a separate PR later today. (Needs updating for Ember v4 types anyway.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't change the semantics at all; it's just a nice win for the clarity and maintainability of the code, and it guarantees that even if we change it (e.g. to re-
throw) in the future, it will always end the test waiter.Thanks to @scalvert for the suggestion!