Fix paths location in type tests tsconfig.json
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
force-pushed
the
fix-type-test-tsconfig
branch
2 times, most recently
from
58cf70a to
d63c6fb
Compare
`paths` should be in the `compilerOptions` hash, and should map from the root of the repo. It should include *only* the addon (not tests) and the path for the destroyable polyfill. In the future, we should revert to using `ember ts:precompile` and look things up from the root again, but this works to unblock us for now.
chriskrycho
force-pushed
the
fix-type-test-tsconfig
branch
from
d63c6fb to
5d5c64b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathsshould be in thecompilerOptionshash, and should map from the root of the repo. It should include only the addon (not tests) and the path for the destroyable polyfill. In the future, we should revert to usingember ts:precompileand look things up from the root again, but this works to unblock us for now.