Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review usages of typing.cast and # type: ignore #34

Open
chrisimcevoy opened this issue Jan 11, 2024 · 0 comments
Open

Review usages of typing.cast and # type: ignore #34

chrisimcevoy opened this issue Jan 11, 2024 · 0 comments

Comments

@chrisimcevoy
Copy link
Owner

chrisimcevoy commented Jan 11, 2024 •
edited
Loading

There are several places (mainly in tests) where typing.cast and # type: ignore are used.

Review these to check that we aren't doing anything untoward.

There may be understandable (if not justified) reasons:

  • The test being ported from Noda Time uses an integer rather than an enum member to test that an ArgumentOutOfRangeException is thrown.
  • TBD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisimcevoy