Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standardise .With() ports #259

Merged
merged 1 commit into from
Jan 26, 2025
Merged

feat: standardise .With() ports #259

merged 1 commit into from
Jan 26, 2025

Conversation

chrisimcevoy
Copy link
Owner

@chrisimcevoy chrisimcevoy commented Jan 26, 2025

Ports .With() methods for types which can be adjusted by "date adjusters" and "time adjusters" in a way which makes sense in Python.

Noda Pyoda
LocalDate.With() LocalDate.with_date_adjuster()
LocalTime.With() LocalTime.with_time_adjuster()
LocalDateTime.With() LocalDateTime.with_date_adjuster() & LocalDateTime.with_time_adjuster()
OffsetDate.With() OffsetDate.with_date_adjuster()
OffsetTime.With() OffsetTime.with_time_adjuster()
OffsetDateTime.With() OffsetDateTime.with_date_adjuster() & OffsetDateTime.with_time_adjuster()

closes #257

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (803825c) to head (0e2f6ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         263      263           
  Lines       20873    20902   +29     
=======================================
+ Hits        20135    20164   +29     
  Misses        738      738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisimcevoy chrisimcevoy merged commit 397e093 into main Jan 26, 2025
9 checks passed
@chrisimcevoy chrisimcevoy deleted the feat/with-adjusters branch January 26, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porting date/time adjuster usage (.With())
1 participant