Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate workspace stopped working #112

Closed
yanivoh opened this issue Apr 7, 2020 · 8 comments
Closed

Populate workspace stopped working #112

yanivoh opened this issue Apr 7, 2020 · 8 comments

Comments

@yanivoh
Copy link

yanivoh commented Apr 7, 2020

Hi,
Populate workspace stopped working for me few weeks a go.
Configure workspace works and creates SPGo.json file, but the populate workspace doesn't do anything.
Tried on multiple sites and document libraries.
This is my SPGo.json file:
{
"sourceDirectory": "src",
"sharePointSiteUrl": "https://sampletenant.sharepoint.com/doccenter",
"publishingScope": "SaveOnly",
"authenticationType": "Digest",
"remoteFolders":
[
"CustomScripts/**/."
]
}

Output says:
[7.4.2020, 16:06:20] ================================ ERROR ================================

[7.4.2020, 16:06:20] Cannot read property 'toString' of undefined
[7.4.2020, 16:06:20] Error Detail:
[7.4.2020, 16:06:20] ----------------------
[7.4.2020, 16:06:20] {}
[7.4.2020, 16:06:20] ===============================================================================

@ghost
Copy link

ghost commented Apr 7, 2020

I am experiencing the same issue.
If I manually create a new folder, manually create the file and contents, i can edit and update the SharePoint source just fine.

@chrishasz
Copy link
Owner

Thank you for bringing this to my attention. I will take a look this week and get you a response soon.

Also- I appreciate you posting your SPGo.json file, it is helpful.

@chrishasz
Copy link
Owner

Hey Everyone- I am able to replicate this issue. I will have a fix out to the marketplace in the next day or so.

@chrishasz
Copy link
Owner

@billr-stcu, @yanivoh -

I have found and fixed a bug with file parsing, but I had a separate question about the glob pattern you are using in the remoteFolders property, because that might be part of your issue.

Are you looking to download all files within the specified folder? If so, the correct glob pattern would be "CustomScripts/**/*". The glob pattern **/. is not recognized by the parser used by SPGo.

I will publish the fix to the marketplace soon, but you may want to try the above as a workaround until then.

@ghost
Copy link

ghost commented Apr 13, 2020

I have been using **/*.* for quite a while. Found the pattern in the documentation.
I just changed to **/* and files are downloading.

@chrishasz
Copy link
Owner

@billr-stcu the *.* notation is correct - I was specifically referring to this notation: **/.

That said, I was still not handling the *.* notation correctly, and that is on me! I've just published 1.6.3 to the VSCode marketplace which will now correctly handle that notation as well.

Thank you for catching this!

@ghost
Copy link

ghost commented Apr 20, 2020

Thanks you for your quick turn on this.
Updated/Tested - All is well.
It's the totality of the simple things that make our lives much richer.
Very much appreciated!
Be safe :)

@chrishasz
Copy link
Owner

(Belated) Thanks @billr-stcu!

I will close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants