Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish flowtype-protoc-gen on npm #5

Closed
3 of 5 tasks
shanshanzhu opened this issue Jan 2, 2019 · 4 comments
Closed
3 of 5 tasks

Publish flowtype-protoc-gen on npm #5

shanshanzhu opened this issue Jan 2, 2019 · 4 comments

Comments

@shanshanzhu
Copy link
Collaborator

shanshanzhu commented Jan 2, 2019

Suggestion: We can use beta version first for testing.

To Do List

Any more thoughts?

@chrisgervang
Copy link
Owner

For now, I don't want to convert to yarn or remove typescript code paths until we've got a stable release out. The original package had a build system in place that used npm, since it works and bazel is set up already - I'd prefer not to change it (instead prioritizing new features).

@shanshanzhu
Copy link
Collaborator Author

Sure. agree with the priority. I move remove typescript specific code path and yarn to other tasks.

For yarn and the build system: it depends on the consumer after it is published on npm.
Example 1: It is used by javascript repo that use yarn for dependency management. Running generate.sh will install dependency in the root node_modules folder that is not tracked in the repo's yarn.lock file. Also javascript repo that use yarn add flowtype-protoc-gen to install this package will install different versions of node_modules from 'package-lock.json' that's in the root repo, but those versions may not be used.

See #8

@chrisgervang
Copy link
Owner

Maybe I'm not familiar enough with yarn. My understanding was that an npm package published with or without yarn will behave the same for the end user installing over npm because they are installing a "built" distribution of the package.

All of the devDependencies are ignored, and we don't have many dependencies

"@babel/polyfill": "^7.0.0",
"google-protobuf": "^3.6.1"

(the poly fill might actually be able to be removed)
It may make sense to move google-protobuf to peerDependency.

@chrisgervang
Copy link
Owner

This is now published in prerelease on npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants