Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow check to unit test #19

Open
shanshanzhu opened this issue Feb 26, 2019 · 0 comments
Open

Add flow check to unit test #19

shanshanzhu opened this issue Feb 26, 2019 · 0 comments

Comments

@shanshanzhu
Copy link
Collaborator

shanshanzhu commented Feb 26, 2019

[ ] Add flow check to unit test
This work break the flowtype but pass the unit test (note the build failed b/c of a bazel issue)
#18
https://travis-ci.org/chrisgervang/flowtype-protoc-gen/builds/498487879

[ ] Optional: Add tests that should break flow in unit test.
All the unit test is checking if the types are correct. We can add some unit tests where flow type is incorrect and catch the proper error count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant