-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smooth MaxPool2D rule #181
Comments
Hey Reduan, thanks for the issue as always! I think having a way to use the AvgPool2d gradient for MaxPool2d layers is a must-have. While going over your code and seeing the I have a different approach of attributing MaxPool in the pipeline, which could benefit from this approach. Do you maybe know of another use-case for arbitrary function override? Or maybe @sebastian-lapuschkin ? If it is only for MaxPool, implementing an explicit rule based on As for the name, maybe its better to call it something like |
Hey,
we'd like to add a new rule that smooths the MaxPool2D operation by replacing it by an AveragePool2D backward pass:
You can test the code with
Do you think that's fine? I can create a pull request if you want.
Best,
Reduan
The text was updated successfully, but these errors were encountered: