Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units of g_k in the code #66

Open
bas-rustenburg opened this issue Dec 9, 2016 · 1 comment
Open

Units of g_k in the code #66

bas-rustenburg opened this issue Dec 9, 2016 · 1 comment

Comments

@bas-rustenburg
Copy link
Member

bas-rustenburg commented Dec 9, 2016

The titration state weight is assumed to be in units of molar energy:
https://github.com/choderalab/protons/blob/master/protons/driver.py#L515

If you store the numbers obtained directly from calibration, this would give you beta^2 * g_k. I overlooked this when setting up the abl-imatinib calculations.
https://github.com/choderalab/protons/blob/master/protons/driver.py#L1836

Maybe we want to make sure that beta is appropriately removed from the results spat out by the calibration, so that the current API works when you store the same numbers in the ffxml file.

Or, we could adjust the code to only takes a unitless reference energy for each state (beta * gK being the standard), to avoid any confusion with unit conversion.

@jchodera
Copy link
Member

jchodera commented Dec 9, 2016

Or, we could adjust the code to only takes a unitless reference energy for each state (beta * gK being the standard), to avoid any confusion with unit conversion.

We only ever want to store g_k and energies as unitless quantities to avoid exactly the issues you are seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants