-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fosshub - Changing to use core extension #350
Conversation
@majkinetor this is the changes I was talking to you about. Trying to change the Fosshub extension to use the new Get-WebContent helper method that was added to the chocolatey-core.extension. However, when I try to run So I changed the update.ps1 to include this:
But this then resulted in the following: If you have a minute, can you look into what might be going on here? Thanks! |
I pushed a new version of AU that fixes this problem. I got new errors tho, but those are not related to GetWeb-Content:
|
@majkinetor when you say you pushed a new version, what does that mean? Can I update through PowerShell Gallery? |
No, download latest artifact, unpack it and run install.ps1. |
@majkinetor okay, installed locally, after updating my clone. Thanks! Any thoughts on this new error then? Is that a package issue? Or something else? |
Didn't have time to investigate it yet. |
Okay, not a problem. |
|
||
$htmlPage = $webClient.DownloadString($linkUrl) | ||
$opts = @{ Headers = @{ Referer = 'https://www.fosshub.com/${fosshubAppName}' } } | ||
$htmlPage = Get-WebContent -url "http://example.com" -options $opts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, no wonder it doesn't work
|
1515c6f
to
1440ddb
Compare
@majkinetor Doh! Thanks for taking a look at this, and fixing it up. I have just rebased this PR to bring it up to date with the latest master branch, and I was confused to find that the commit where I moved the packages to use the new core extension was removed. When I checked, it looks like it already got merged into master. This happened here: Not entirely sure how that managed to happen, but it looks like it got pulled in when you were merging the jitsi package. All that was left in this PR was the single commit that is still here, where you changed example.com to the correct |
@majkinetor also, I still don't get the above I have updated to the latest AU version, thinking that you added something in there, but still no joy. |
I was moving between branches and when quickly testing your stuff back then I accidentally pushed some of my unreleated work - so its probably merged because of it.... sorry. I took care that it doesn't happen in the future, current branch is now VERY visible in shell. I will recheck again to see if I can reproduce. |
What changes have you made?
Thank you, appreciate it! |
SImilar to posh-git but in my prompt function within my profile.d. |
Fixed in au. |
No description provided.