Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version constraints #7

Closed
mvorisek opened this issue Apr 8, 2020 · 3 comments
Closed

Add version constraints #7

mvorisek opened this issue Apr 8, 2020 · 3 comments

Comments

@mvorisek
Copy link

mvorisek commented Apr 8, 2020

Migrated from ansible-collections/community.windows#39

This is a feature request. I propose to add version range constraint support to accept versions like [7.3, 7.4).

Chocolatey has no native support, hovewer the Chocolatey can lookup all versions like choco list php --by-id-only -a (or with `-e switch once chocolatey/choco#1843 is solved). So I propose to allow to specify version by version range constraint, find the latest stable version and then proceed with instal of the discovered/fixed version.

@vexx32 vexx32 added the Improvement Issues that enhances existing functionality, or adds new features label Apr 8, 2020
@vexx32
Copy link
Member

vexx32 commented Apr 11, 2020

Ideally this would be done in tandem with native Chocolatey support for this kind of thing. However, in the interim it's plausible a "good enough" solution can be added to this module to bridge the gap.

I'll mark this up for grabs for now in case other folks want to have a stab at it before one of us gets around to it, but I'll make a note to check back and see what an implementation would look like when I have some time available. 🙂

@vexx32 vexx32 added the Up For Grabs Issues that are available by the community to work on label Apr 11, 2020
@vexx32 vexx32 added the 1 - Ready Issue is accepted, milestone added and are ready to be worked on label May 11, 2021
@vexx32 vexx32 added Invalid / Not Issue / No repro / Not Implementing and removed 1 - Ready Issue is accepted, milestone added and are ready to be worked on Improvement Issues that enhances existing functionality, or adds new features Up For Grabs Issues that are available by the community to work on labels Jun 2, 2021
@vexx32
Copy link
Member

vexx32 commented Jun 2, 2021

Had an internal discussion with the team. We agree that this collection is probably not the right place to put this logic. As I noted above, this should be supported from the choco side rather than the collection. If we build logic for this in the collection, we may run the risk of it breaking in future if the version resolution logic differs slightly in choco itself.

@vexx32 vexx32 closed this as completed Jun 2, 2021
@mvorisek
Copy link
Author

mvorisek commented Jun 2, 2021

I understand, related with chocolatey/choco#800 , 👍 there if interested in this feature and if you can, please help with the impl. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants