Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#1861) This improves the terminology in choco.exe help output #1886

Merged
merged 1 commit into from
Apr 18, 2021
Merged

(#1861) This improves the terminology in choco.exe help output #1886

merged 1 commit into from
Apr 18, 2021
+6 −6

Conversation

mprasanth
Copy link
Contributor

@mprasanth mprasanth commented Jul 20, 2019 •
edited by gep13
Loading

This improves the terminology in choco.exe help output with the suggestions and new terminology.

Fixes #1861

ferventcoder
ferventcoder requested changes Aug 16, 2019
View reviewed changes
Copy link
Member

@ferventcoder ferventcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mprasanth - thanks so much for the contribution. There are a couple of aspects to clean up. Also the commit message itself will need to be adjusted to adhere to CONTRIBUTING. If you have not had a chance to review that, now would be a good opportunity as you fix up this PR. Thanks in advance, let us know if you need any help!

@ferventcoder ferventcoder mentioned this pull request Aug 27, 2019
Closed
@CLAassistant
Copy link

CLAassistant commented Jun 8, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gep13
Copy link
Member

gep13 commented Apr 18, 2021

While the new cla-assistant.io may not have been signed, the original CLAHub one has been signed, as such, we can move forward with this PR:

image

@gep13 gep13 force-pushed the help-command-enhancements branch from ed1e77d to 901ad70 Compare April 18, 2021 19:18
@gep13 gep13 changed the base branch from master to stable April 18, 2021 19:18
@gep13 gep13 force-pushed the help-command-enhancements branch from 901ad70 to 5daade7 Compare April 18, 2021 19:30
@mprasanth @gep13
(chocolatey#1861) Improves terminology in help documentation
43c99ec 
Some suggestions were made on how the help documentation for various
commands could be improved, making them less subjective.
@gep13 gep13 force-pushed the help-command-enhancements branch from 5daade7 to 43c99ec Compare April 18, 2021 19:38
gep13
gep13 approved these changes Apr 18, 2021
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 changed the title (GH-1861) - This improves the terminology in choco.exe help output - fixes #1861 (#1861) This improves the terminology in choco.exe help output Apr 18, 2021
@gep13 gep13 merged commit 2e31696 into chocolatey:stable Apr 18, 2021
@gep13
Copy link
Member

gep13 commented Apr 18, 2021

@mprasanth thanks again for your help in getting this updated, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdmiringWorm AdmiringWorm AdmiringWorm left review comments

@ferventcoder ferventcoder ferventcoder requested changes

@gep13 gep13 gep13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mprasanth @CLAassistant @gep13 @ferventcoder @AdmiringWorm