Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing new version with meta-package doesn't uninstall cleanly #1368

Open
flcdrg opened this issue Jul 27, 2017 · 1 comment
Open

Forcing new version with meta-package doesn't uninstall cleanly #1368

flcdrg opened this issue Jul 27, 2017 · 1 comment

Comments

@flcdrg
Copy link
Member

flcdrg commented Jul 27, 2017

(Initially raised in chocolatey/cChoco#91)

Given a machine that had successfully ran:

  cChocoPackageInstaller node {
    Name = "nodejs"
    Version = "8.1.0"
    DependsOn = @("[cChocoInstaller]Chocolatey")
  } 

Then if that is updated to

  cChocoPackageInstaller node {
    Name = "nodejs"
    Version = "8.2.1"
    DependsOn = @("[cChocoInstaller]Chocolatey")
  }

Then the old version is uninstalled and it appears to fail to handle the nodejs/nodejs.install combination (it prompts whether to uinstall nodejs.install but immediately continues assuming no response).

Here is the relevant extract from chocolatey.log

2017-07-24 23:30:32,447 5732 [INFO ] - Chocolatey v0.10.7
2017-07-24 23:30:32,824 5732 [INFO ] - Uninstalling the following packages:
2017-07-24 23:30:32,826 5732 [INFO ] - nodejs
2017-07-24 23:30:33,465 5732 [WARN ] - You are uninstalling nodejs, which is likely a metapackage for an
.install/.portable package that it installed
(nodejs represents discoverability).
2017-07-24 23:30:33,490 5732 [INFO ] - For the question below, you have 20 seconds to make a selection.
2017-07-24 23:30:33,491 5732 [INFO ] - Would you like to uninstall nodejs.install as well?
2017-07-24 23:30:33,491 5732 [INFO ] - 1) yes
2017-07-24 23:30:33,492 5732 [INFO ] - 2) no
2017-07-24 23:30:53,502 5732 [ERROR] - Timeout or your choice of '' is not a valid selection.
2017-07-24 23:30:57,561 5732 [INFO ] - [NuGet] Uninstalling 'nodejs 8.1.4'.
2017-07-24 23:30:57,568 5732 [INFO ] -
nodejs v8.1.4
2017-07-24 23:30:57,598 5732 [INFO ] - Skipping auto uninstaller - No registry snapshot.
2017-07-24 23:30:57,707 5732 [INFO ] - [NuGet] Successfully uninstalled 'nodejs 8.1.4'.
2017-07-24 23:30:57,736 5732 [INFO ] - nodejs has been successfully uninstalled.
2017-07-24 23:30:57,795 5732 [WARN ] -
Chocolatey uninstalled 1/2 packages.
See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Everything ends up ok eventually as when the new version is installed then that results with nodejs and nodejs.install both being at 8.2.1

@ferventcoder
Copy link
Member

So it uninstalls to upgrade first? That is strange, very strange.

The aspect of it failing is there is no choice should not fail, and that belongs here.

@ferventcoder ferventcoder changed the title Forcing new version with cChocoPackageInstaller with meta-package doesn't uninstall cleanly Forcing new version with meta-package doesn't uninstall cleanly Jul 28, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.8, 0.10.9 Aug 29, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.9, 0.10.10 Feb 27, 2018
@ferventcoder ferventcoder modified the milestones: 0.10.10, 0.10.11 Mar 27, 2018
@ferventcoder ferventcoder modified the milestones: 0.10.11, 0.10.12 May 3, 2018
@ferventcoder ferventcoder modified the milestones: 0.10.12, 0.10.13, 0.10.14 Mar 9, 2019
@ferventcoder ferventcoder modified the milestones: 0.10.14, 0.10.15 Apr 1, 2019
@gep13 gep13 modified the milestones: 0.10.15, 0.10.16 May 31, 2019
@ferventcoder ferventcoder modified the milestones: 0.10.16, 0.10.17 Jan 14, 2020
@ferventcoder ferventcoder modified the milestones: 0.10.17, 0.10.x Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants