-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install-ChocolateyPackage redirects to https when not supported #1221
Comments
This seems like an issue on nlite's end? |
yes and no IMO. |
The reason the referer header is lost though, is because they define the following referer policy: |
@AdmiringWorm you've got
probably 0.10.4 ? - just thinking how this could be misleading when there really is a 0.14 someday :-) |
@mwallner ops yeah, fixed. |
@AdmiringWorm Chocolatey detects if there is TLS/SSL available prior to flipping over. So either the detection needs more work - or they have TLS/SSL but are not fully opted in. |
For all I know it could be that they haven't fully opted in to TLS/SSL. |
Chocolatey simply makes a determination if TLS/SSL is available. Sounds like they are doing something maybe we need to detect better for. Fair? |
yeah, that sounds fair. |
for reference, here is the source for the nlite package I found this issue for: |
What You Are Seeing?
Choco tries to redirect http to https when the https version just redirects back to http.
This messes up downloads that needs to set the Referer header (since it clears the referer header on downgrades).
What is Expected?
Choco to not redirect to https when it only redirects back to http.
How Did You Get This To Happen? (Steps to Reproduce)
Tried updating the nlite package with the following code:
then try the usual choco install
Environment
OS: Windows Server 2012R2 (Test Environment)
Choco v: 0.10.4-beta1
Output Log
The text was updated successfully, but these errors were encountered: