cChocoInstaller - Use SSLv3 only for powershell 5 or lower versions #183
Conversation
|
I'd like to add tests for this, but I believe this would require different appveyor setups using different powershell versions (5 or less, 6, and 7). It was not clear to me how to test across multiple powershell versions. I'm happy to update if I could get some guidance on how best to get that done. |
|
Would love to see this Pull request get in. I'm facing the same issue, especially now I'm trying out the Guest Configuration. |
|
@coderjoe just tested out your change locally. You've to add the $securityProtocolSettingsOriginal = [System.Net.ServicePointManager]::SecurityProtocol to keep the original. Otherwise it throws an error :) |
|
What a silly thing to miss. Thank you very much for the test @Gijsreyn! Had some local upstaged changes that somehow got missed in the first commit. I'll have to re-test Monday to make sure there isn't anything else I've missed. 👍 |
Powershell 6 deprecates and removes SSLv3 from the list of supported SecurityProtocolTypes. This resultes in the resource throwing an error on versions 6 or higher. Resolve the issue by only requesting Ssl3 on versions lower than 6 where it is still supported. Fixes: chocolatey#182 Relates to: chocolatey#173
coderjoe
force-pushed
the
bug/skip.ssl3.for.powershell.6plus
branch
from
5eec933 to
98da582
Compare
|
@coderjoe No worries champ. Was already glad you had an open pull request here with the fix :) |
|
Why does it take so long to merge? I would like to use it in Azure Policies Guest Configuration as well, but becasue of this, it is not possible. Thanks! |
Description Of Changes
Update the cChocoInstaller to only use SSLv3 for versions lower than Powershell 6
Motivation and Context
SSLv3 was deprecated and removed in Powershell 6+ resulting in the resource throwing an error:
Exception setting "SecurityProtocol": "The requested security protocol is not supported."Omitting SSLv3 resolved this issue in Powershell 6 and 7 for my use cases.
Testing
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Relates to #182 and possibly #173
Fixes #182