Install Aware MSI don't like to be renamed

[jamiecook]

You wouldn't think it was still an issue in this day and age but apparently install aware does some very funny stuff with their msi which precludes you from renaming them.

http://www.installaware.com/forum/viewtopic.php?f=2&t=5532

(best reply from tech illiterate support I've ever seen in that forum)

The solution for this very specific problem comes from here I think:

https://github.com/chocolatey/chocolatey/blob/master/src/helpers/functions/Install-ChocolateyPackage.ps1#L77

If instead of downloading the file to a ${App}Install.${EXTENSION} it just used the original filename it would avoid this particular problem.
I am probably missing something very important about why it uses the alternate filename though

[ferventcoder]

Not missing much important other than a naive implementation ensuring the name of the file.

[ferventcoder]

I think this may be covered by another issue...?

[jamiecook]

Are you happy for me to create a pull request with the proposed structure?

Is that (currently assured) assumption about the filename used in other places? The helper method actually returns the full path to the file that it saves so you would imagine that that is what is being used subsequently in the flow but I haven't actually checked

[ferventcoder]

Migrated to chocolatey/choco#435