Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows LLVM to version 15 until bazel 6.4 #2014

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

corco
Copy link
Collaborator

@corco corco commented Sep 18, 2023

Bazel fails with LLVM 16, which is now installed on Windows CI.

Fix version 15 for now.

The issue is resolved in bazel, but not released yet.

@corco corco force-pushed the fix-windows-fail-llvm-16 branch from 7df0ef1 to b496c2e Compare September 18, 2023 19:39
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 92.12% and project coverage change: -0.01% ⚠️

Comparison is base (0b8cb4e) 92.85% compared to head (7df0ef1) 92.85%.
Report is 11 commits behind head on master.

❗ Current head 7df0ef1 differs from pull request most recent head b496c2e. Consider uploading reports for the commit b496c2e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
- Coverage   92.85%   92.85%   -0.01%     
==========================================
  Files         355      357       +2     
  Lines       26272    26399     +127     
==========================================
+ Hits        24395    24512     +117     
- Misses       1877     1887      +10     
Files Changed Coverage Δ
common/util/sha256.cc 92.00% <92.00%> (ø)
common/util/sha256.h 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hzeller
Copy link
Collaborator

hzeller commented Sep 18, 2023

Fixes #2013 - thanks @corco

I'll wait for the Windows build to pass, then merge.

@hzeller hzeller merged commit ccbe173 into chipsalliance:master Sep 18, 2023
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants