Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounded corners of rectangular containers & buttons #185

Closed
mar-bi opened this issue Jan 10, 2018 · 2 comments · Fixed by #207
Closed

Rounded corners of rectangular containers & buttons #185

mar-bi opened this issue Jan 10, 2018 · 2 comments · Fixed by #207
Assignees
@mar-bi
Labels
enhancement style

Comments

@mar-bi
Copy link
Contributor

mar-bi commented Jan 10, 2018 •
edited
Loading

Candies 🍬 for Material UI fans.

Started at #1 (comment)

Find, check and add

border-radius: 2px;

for all rectangular containers & buttons.
@spences10
Copy link
Collaborator

Ok, there were quite a few components I added with border-radius: 4px; so maybe we want to amend those too so everything is consistent 👌

@mar-bi mar-bi added the next label Jan 18, 2018
@mar-bi
Copy link
Contributor Author

mar-bi commented Jan 23, 2018

Let's amend only components which have to look rectangular and keep rounded what is already rounded 🙃
This will not cause changes to the design. It will make the rectangular stuff more "Material".
A tiny piece of 🌶️

border-radius: 2px;

It works fine. 🙃

@mar-bi mar-bi mentioned this issue Jan 23, 2018
Merged
@mar-bi mar-bi added review and removed next labels Jan 23, 2018
@miljan-fsd miljan-fsd mentioned this issue Jan 23, 2018
Merged
@mar-bi mar-bi removed the review label Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mar-bi mar-bi

Labels
enhancement style
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Development chingu-voyage6/grad.then
3 participants
@spences10 @miljan-fsd @mar-bi