forked from FreeRTOS/FreeRTOS-Kernel
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update coverity violation for SMP #81
Merged
chinglee-iot
merged 134 commits into
smp-dev-complete-merge-candidate-history
from
merge-main-misra-SMP-rebase20221130
May 16, 2023
Merged
Update coverity violation for SMP #81
chinglee-iot
merged 134 commits into
smp-dev-complete-merge-candidate-history
from
merge-main-misra-SMP-rebase20221130
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinglee-iot
commented
Apr 27, 2023
chinglee-iot
commented
Apr 27, 2023
chinglee-iot
commented
Apr 27, 2023
chinglee-iot
commented
Apr 27, 2023
chinglee-iot
commented
Apr 27, 2023
chinglee-iot
commented
Apr 27, 2023
chinglee-iot
commented
Apr 27, 2023
chinglee-iot
commented
Apr 27, 2023
Signed-off-by: Gaurav Aggarwal <[email protected]>
Signed-off-by: Gaurav Aggarwal <[email protected]>
* Remove taskTASK_IS_YIELDING since it is not used anymore. * Define taskYIELD_IF_USING_PREEMPTION for single core only. SMP uses prvYieldForTask or vTaskieldWithinAPI. The conditiion is not the same. * Define taskSELECT_HIGHEST_PRIORITY_TASK for single core only. SMP doesn't support configUSE_PORT_OPTIMISED_TASK_SELECTION now.
aggarg
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix coverity violations for SMP diff part.
Description
Fix coverity violations for SMP diff part.
SMP diff part is generated by comparing the coverity report of single core and SMP.
The coverity violations with SMP are already fixed in the implementation. The coverify report only shows violations in single core ( common code ). Single core FreeRTOS are checked by another tool "Lint". The reason for violation is documented with lint suppression comment.
The following is a lint suppression example:
The tasks.c coverity errors for single core
Test Steps
Generate SMP coverity report
cov-configure --force --compiler cc --comptype gcc -- -std=gnu90
cov-build --emit-complementary-info --dir cov-out make multicore1
or
cov-build --emit-complementary-info --dir cov-out make multicore2
cd cov-out/
cov-analyze --dir . --coding-standard-config ../coverity_misra.config
cov-format-errors --dir . --file "Source/tasks.c" --exclude-files '(/Test/|/Source/portable/)' --html-output html-out;
Generate single core coverity report
cov-configure --force --compiler cc --comptype gcc -- -std=gnu90
cov-build --emit-complementary-info --dir cov-out make singlecore
cd cov-out/
cov-analyze --dir . --coding-standard-config ../coverity_misra.config
cov-format-errors --dir . --file "Source/tasks.c" --exclude-files '(/Test/|/Source/portable/)' --html-output html-out;
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.