Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken parsing validation on double commas within arrays #317

Open
steffanmusokedd opened this issue Oct 12, 2023 · 1 comment
Open

Broken parsing validation on double commas within arrays #317

steffanmusokedd opened this issue Oct 12, 2023 · 1 comment

Comments

@steffanmusokedd
Copy link

What:

When parsing an array with two consecutive commas, no parsing error is thrown. In this case we should expect a syntax error.

ex.

array = [1, 2, , 3, 4]

Potential issue:

Looks like there was a workaround for trailing commas that likely is root cause.
https://github.com/chimpler/pyhocon/blob/master/pyhocon/config_parser.py#L754-L764

@davlee1972
Copy link

davlee1972 commented Feb 21, 2025

See #232

There should be pre parsing checks that looks for consecutive commas and throws errors.

The post processing should not reject empty strings in arrays. Right now “” is getting tossed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants