-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG output lines between paths #57
Comments
Hey, it seems that's rather a browser issue, specifically rendering. The distance between the blocks should be 0 and there should not be a visible line regardless. I can see these lines too and it also depends on the browser's current zoom and changes with the zoom level, in both, chrome and firefox. As for the generation: at least the blocks of the same color in the same line should be connected and i found a bug that prevents this. I'll look into it as soon as i can but it's low priority as i'm currently revamping some internals. I can leave the issue open and tag it as "help needed" as i don't know too much about SVG to find an easy way how to fix it (one of which would be to connect all modules of the same color). Right now i can only suggest to use png output in case it's bothering. |
Sounds good, thanks for the fast response I'll use the PNG temporary and probably dig a bit more about the issue itself. Again thank you for the help. |
Another update: it looks like the lines were caused by the modules being in different |
Great! Thank you for taking the time to look into this. Awesome work! |
Hi,
I've noticed that outputting the QR code as SVG generates SVG with lines that look like borders on some squares. I haven't managed to figure out what exactly those lines are, stroke, outline or just misalignment of paths, it seems like they are transparent. Here is a screenshot of SVG versus the PNG output so its easier to notice what I'm talking about.
My QR options are:
_
'version' => 6,
'eccLevel' => QRCode::ECC_L,
'outputType' => QRCode::OUTPUT_MARKUP_SVG,
'imageBase64' => false
_
Can you try recreating the issue and looking into it please, maybe I'm doing something wrong. Thank you ahead!
The text was updated successfully, but these errors were encountered: