Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support to PHP 8.4 #124

Closed
Lukasss93 opened this issue Nov 27, 2024 · 3 comments
Closed

Add full support to PHP 8.4 #124

Lukasss93 opened this issue Nov 27, 2024 · 3 comments

Comments

@Lukasss93
Copy link

Please add support to PHP 8.4

@le0m le0m linked a pull request Nov 27, 2024 that will close this issue
@le0m le0m removed a link to a pull request Nov 27, 2024
@le0m le0m changed the title Add support to PHP 8.4 Add full support to PHP 8.4 Nov 27, 2024
@le0m le0m pinned this issue Nov 27, 2024
@le0m
Copy link
Member

le0m commented Nov 27, 2024

Thanks for the reminder.

I'm keeping this issue open & pinned because there are still some problems with xdebug and pcov:

  • xdebug stable does not yet support PHP 8.4 (using beta version in our image, I'm monitoring their releases) xdebug 3.4.0 stable is out
  • pcov has an error because of a PHP internal function changing signature (monitoring the PR); this version cannot be installed from source because the branch is missing the package.xml file (it is available only in their release branch) and I really didn't want to write a convoluted workaround to clone the correct files in a local directory and install it from there, so I disabled the build of our pcov image for PHP 8.4

@s3bsch
Copy link

s3bsch commented Nov 29, 2024

The images arrived at Docker Hub and work as expected! 👏 🙏

@le0m
Copy link
Member

le0m commented Dec 5, 2024

Both xdebug and pcov have been updated, new images are building now

@le0m le0m closed this as completed Dec 5, 2024
@le0m le0m unpinned this issue Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants