From 651fdbb9bbd7c7c3eacadbc7b3f8425a2343a6ed Mon Sep 17 00:00:00 2001 From: Akash Pargat Date: Fri, 5 Aug 2022 15:44:24 -0500 Subject: [PATCH] Fixed swagger bugs (#4) * Fixed swagger bugs * Addressed comments * Updated description * Added performancePlus property * Updated description for performance plus * Addressed comments * Removed read Only property Co-authored-by: akashpargat --- .../DiskRP/stable/2022-07-02/disk.json | 6 ++ .../stable/2022-07-02/diskRPCommon.json | 4 ++ .../Disk_Create_PerformancePlus.json | 45 ++++++++++++ .../Disk_Create_WithUltraSSD_ReadOnly.json | 68 ++++++++++++++++++ .../Snapshot_GetIncrementalSnapshot.json | 71 +++++++++++++++++++ .../DiskRP/stable/2022-07-02/snapshot.json | 5 ++ 6 files changed, 199 insertions(+) create mode 100644 specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/diskExamples/Disk_Create_PerformancePlus.json create mode 100644 specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/diskExamples/Disk_Create_WithUltraSSD_ReadOnly.json create mode 100644 specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/snapshotExamples/Snapshot_GetIncrementalSnapshot.json diff --git a/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/disk.json b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/disk.json index 78a3c52e3636..58f1f4af33e1 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/disk.json +++ b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/disk.json @@ -720,6 +720,12 @@ "type": "string", "description": "ARM id of the DiskAccess resource for using private endpoints on disks." }, + "burstingEnabledTime": { + "type": "string", + "readOnly": true, + "format": "date-time", + "description": "Latest time when bursting was last enabled on a disk." + }, "tier": { "type": "string", "description": "Performance tier of the disk (e.g, P4, S10) as described here: https://azure.microsoft.com/en-us/pricing/details/managed-disks/. Does not apply to Ultra disks." diff --git a/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/diskRPCommon.json b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/diskRPCommon.json index 38d10e999c4c..f32670fd8eb5 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/diskRPCommon.json +++ b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/diskRPCommon.json @@ -360,6 +360,10 @@ "securityDataUri": { "type": "string", "description": "If createOption is ImportSecure, this is the URI of a blob to be imported into VM guest state." + }, + "performancePlus": { + "type": "boolean", + "description": "Set this flag to true to get a boost on the performance target of the disk deployed, see here on the respective performance target. This flag can only be set on disk creation time and cannot be disabled after enabled." } }, "required": [ diff --git a/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/diskExamples/Disk_Create_PerformancePlus.json b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/diskExamples/Disk_Create_PerformancePlus.json new file mode 100644 index 000000000000..151859864195 --- /dev/null +++ b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/diskExamples/Disk_Create_PerformancePlus.json @@ -0,0 +1,45 @@ +{ + "parameters": { + "subscriptionId": "{subscription-id}", + "resourceGroupName": "myResourceGroup", + "api-version": "2022-07-02", + "diskName": "myDisk", + "disk": { + "location": "West US", + "properties": { + "creationData": { + "createOption": "Upload", + "performancePlus": true + } + } + } + }, + "responses": { + "202": { + "body": { + "properties": { + "creationData": { + "createOption": "Upload", + "performancePlus": true + }, + "provisioningState": "Updating" + }, + "location": "West US", + "name": "myDisk" + } + }, + "200": { + "body": { + "properties": { + "creationData": { + "createOption": "Upload", + "performancePlus": true + }, + "provisioningState": "Updating" + }, + "location": "West US", + "name": "myDisk" + } + } + } +} diff --git a/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/diskExamples/Disk_Create_WithUltraSSD_ReadOnly.json b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/diskExamples/Disk_Create_WithUltraSSD_ReadOnly.json new file mode 100644 index 000000000000..dc9120d28235 --- /dev/null +++ b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/diskExamples/Disk_Create_WithUltraSSD_ReadOnly.json @@ -0,0 +1,68 @@ +{ + "parameters": { + "subscriptionId": "{subscription-id}", + "resourceGroupName": "myResourceGroup", + "api-version": "2022-07-02", + "diskName": "myUltraReadOnlyDisk", + "disk": { + "location": "West US", + "sku": { + "name": "UltraSSD_LRS" + }, + "properties": { + "creationData": { + "createOption": "Empty", + "logicalSectorSize": 4096 + }, + "diskSizeGB": 200, + "diskIOPSReadWrite": 125, + "diskMBpsReadWrite": 3000, + "readOnly": true, + "encryption": { + "type": "EncryptionAtRestWithPlatformKey" + } + } + } + }, + "responses": { + "202": { + "body": { + "properties": { + "creationData": { + "createOption": "Empty" + }, + "diskSizeGB": 200, + "provisioningState": "Updating" + }, + "readOnly": true, + "location": "West US", + "name": "myUltraReadOnlyDisk", + "sku": { + "name": "UltraSSD_LRS", + "tier": "Ultra" + } + } + }, + "200": { + "body": { + "properties": { + "creationData": { + "createOption": "Empty" + }, + "diskSizeGB": 200, + "provisioningState": "Updating" + }, + "encryption": { + "type": "EncryptionAtRestWithPlatformKey" + }, + "readOnly": true, + "location": "West US", + "name": "myUltraReadOnlyDisk", + "sku": { + "name": "UltraSSD_LRS", + "tier": "Ultra" + } + } + } + } +} diff --git a/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/snapshotExamples/Snapshot_GetIncrementalSnapshot.json b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/snapshotExamples/Snapshot_GetIncrementalSnapshot.json new file mode 100644 index 000000000000..bcb7212a9408 --- /dev/null +++ b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/examples/snapshotExamples/Snapshot_GetIncrementalSnapshot.json @@ -0,0 +1,71 @@ +{ + "parameters": { + "subscriptionId": "{subscription-id}", + "resourceGroupName": "myResourceGroup", + "api-version": "2022-07-02", + "snapshotName": "myIncrementalSnapshot" + }, + "responses": { + "200": { + "body": { + "properties": { + "osType": "Windows", + "hyperVGeneration": "V1", + "purchasePlan": { + "name": "test_sku", + "publisher": "test_test_pmc2pc1", + "product": "marketplace_vm_test" + }, + "supportedCapabilities": { + "acceleratedNetwork": true + }, + "supportsHibernation": true, + "creationData": { + "createOption": "Copy", + "sourceResourceId": "/subscriptions/{subscription-id}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/disks/myDisk", + "sourceUniqueId": "d633885d-d102-4481-901e-5b2413d1a7be" + }, + "diskSizeGB": 100, + "encryptionSettingsCollection": { + "enabled": true, + "encryptionSettings": [ + { + "diskEncryptionKey": { + "sourceVault": { + "id": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.KeyVault/vaults/myVMVault" + }, + "secretUrl": "https://myvmvault.vault-int.azure-int.net/secrets/{secret}" + }, + "keyEncryptionKey": { + "sourceVault": { + "id": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.KeyVault/vaults/myVMVault" + }, + "keyUrl": "https://myvmvault.vault-int.azure-int.net/keys/{key}" + } + } + ] + }, + "encryption": { + "type": "EncryptionAtRestWithPlatformKey" + }, + "incremental": true, + "networkAccessPolicy": 0, + "diskState": 0, + "diskSizeBytes": 10737418240, + "uniqueId": "a395e9c1-fb9e-446e-a9ba-7b2fa0bcd305", + "incrementalSnapshotFamilyId": "d1a341d5-1ea7-4a85-b304-944ad8021639", + "timeCreated": "2016-12-28T04:41:35.079872+00:00", + "provisioningState": "Succeeded" + }, + "type": "Microsoft.Compute/snapshots", + "location": "westus", + "tags": { + "department": "Development", + "project": "Snapshots" + }, + "id": "/subscriptions/{subscriptionId}/resourceGroups/myResourceGroup/providers/Microsoft.Compute/snapshots/myIncrementalSnapshot", + "name": "myIncrementalSnapshot" + } + } + } +} diff --git a/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/snapshot.json b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/snapshot.json index 813299b78b8a..81d5973af885 100644 --- a/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/snapshot.json +++ b/specification/compute/resource-manager/Microsoft.Compute/DiskRP/stable/2022-07-02/snapshot.json @@ -561,6 +561,11 @@ "type": "boolean", "description": "Whether a snapshot is incremental. Incremental snapshots on the same disk occupy less space than full snapshots and can be diffed." }, + "incrementalSnapshotFamilyId": { + "type": "string", + "readOnly": true, + "description": "Incremental snapshots for a disk share an incremental snapshot family id. The Get Page Range Diff API can only be called on incremental snapshots with the same family id." + }, "encryption": { "$ref": "./diskRPCommon.json#/definitions/Encryption", "description": "Encryption property can be used to encrypt data at rest with customer managed keys or platform managed keys."