Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Https support #8

Open
ionelmc opened this issue Oct 30, 2013 · 6 comments
Open

Https support #8

ionelmc opened this issue Oct 30, 2013 · 6 comments

Comments

@ionelmc
Copy link

ionelmc commented Oct 30, 2013

Would be nice to have the bookmarklet not load http content.

@glajchs
Copy link

glajchs commented May 20, 2014

The bookmark doesn't work for me in firefox on https sites, due to the fact that it only loads via http. You get an error about blocking mixed content. I realize I could change my firefox settings away form defaults to allow this, but it would be nice if I didn't have to.

I also tried hardcoding it to https, but this does't work as the resource isn't available over https. Two things need to be done here:

  1. Need to serve up the JS at HTTPS as well at "https://chengyinliu.com/wf.js"
  2. Need to change the scriptlet to point to whatever protocol the page is using
    change:
    s.setAttribute('src','https://chengyinliu.com/wf.js.....
    to:
    s.setAttribute('src',document.location.protocol + '://chengyinliu.com/wf.js.....

@exalted
Copy link

exalted commented Oct 6, 2015

👍

Broken on Safari 9 now as well.

@phnah
Copy link

phnah commented Oct 15, 2015

Since I cannot access chengyinliu.com to fix the https error. I fixed this by serving the files using Rawgit

The changed version is here: https://gist.github.com/hanhpho/6578e7033a3fc0288ba8

@exalted
Copy link

exalted commented Oct 15, 2015

@hanhpo darn... That's clever! 👏👏

@ntwb
Copy link

ntwb commented May 16, 2017

Neat solution @hanhpho 👍 , that said I'd love to see this fixed here...

(With the latest Chrome it's also now blocking the script)

cc @chengyin

@phuang07
Copy link

Well done. @hanhpho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants