Better logging control #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This commit adds a new internal package called logging. It exposes the Logger interface. The package also includes two loggers that implement the Logger interface. TEXT - this logger uses zerolog and will print out a sequential list of events. SPINNER - even though this is technically not a logger, this option implements a spinner that is used to display events. The type of logger used is determined by the LoggerType options. The LoggerType is passed to the constructor which will return the correct logging implementation.
This commit implements the logging package. The builder is not aware of the specific implementation of the logger, it just cares about methods exposed by the Logger interface.
This commit removes the 's' from tags so that the output looks better when using text-mode logging.
chelnak
force-pushed
the
logging
branch
2 times, most recently
from
7bc4cb0 to
5a86bef
Compare
This commit adds the environment package. It currently contains one function that is used to determine whether or not the app is running in CI. For most popular CI products this assertion is made by including an environment variable called `CI`. IsCI checks for the existence of this environment variable. If it is set to true then we return a boolean true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new internal package called logging. It exposes the Logger interface. The package also includes two loggers that implement the Logger interface.
TEXT - this logger uses zerolog and will print out a sequential list of events.
SPINNER - even though this is technically not a logger, this option implements a spinner that is used to display events.
The type of logger used is determined by the LoggerType options. The LoggerType is passed to the constructor which will return the correct logging implementation.