AIX: Set os_version to match the output of oslevel -s #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
major version of AIX.
| @@ -25,6 +25,6 @@ | |||
|
|
|||
| collect_data(:aix) do | |||
| os collect_os | |||
| os_version kernel[:version] | |||
| os_version shell_out("oslevel -s").stdout.split($/)[0] | |||
There was a problem hiding this comment.
It's to hedge against whitespace appearing after the command output. Sometimes IBM utilities are not clean on this front.
There was a problem hiding this comment.
Could you add or modify the the existing test to include a shell out result with trailing whitespace?
There was a problem hiding this comment.
Done. By whitespace I meant linebreak :-)
There was a problem hiding this comment.
So any reason not to just use .strip here?
There was a problem hiding this comment.
Could do that too; I was just copying the style from the rest of the AIX plugins. You'd prefer .strip then I take it?
There was a problem hiding this comment.
It's a lot more clear what you're trying to do with .strip
|
👍 |
1 similar comment
|
👍 |
tas50
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #693.