Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XML output in VirtualizationInfo and need for hpricot gem #755

Merged
merged 1 commit into from
Mar 9, 2016

Commits on Mar 3, 2016

  1. VirtualizationInfo plugin cleanup

    This is an early plugin that hasn't received any work since it's creation.  I seriously doubt anyone is using it, but this provides some minor cleanup
    
    1) remove the hpricot dependency and all the commented out hpricot code. This plugin would fail unless it was installed, but it's not actually used
    2) Stop storing XML data on the node. This is a horrible horrible thing to do. We're storing the exact same data in JSON. Why 2 formats?
    3) Change the debug message to make it clean what plugin fails if the gems aren't there
    4) Add a comment telling anyone reading this what gem to use.  The libvirt gem is deprecated and fails to load.
    
    It's a bummer we need this gem to use this because the data is actually pretty useful once it's loaded, but I doubt anyone installs the gem.
    tas50 committed Mar 3, 2016
    Configuration menu
    Copy the full SHA
    55fec1b View commit details
    Browse the repository at this point in the history