Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_package.sh filename incorrectly extracted #368

Closed
jeremy-clerc opened this issue Aug 13, 2021 · 0 comments · Fixed by #369
Closed

fetch_package.sh filename incorrectly extracted #368

jeremy-clerc opened this issue Aug 13, 2021 · 0 comments · Fixed by #369
Labels
Status: Untriaged An issue that has yet to be triaged. Type: Bug Does not work as expected.

Comments

@jeremy-clerc
Copy link
Contributor

Version:

v3.12.15

Environment:

Running any kitchen test

Scenario:

bundle exec kitchen converge default

Steps to Reproduce:

Just to be sure, I have not and cannot test without an overriden url, so in your kitchen config:

          provisioner:
            product_name: 'chef',
            product_version: '14.7.17',
            download_url: 'http://<some url to the rpm>/chef-14.7.17-1.el7.x86_64.rpm'

Expected Result:

       Download URL override specified
       /tmp/kitchen/chef-14.7.17-1.el7.x86_64.rpm not found
       downloading http://<internal repo url>/opscode-CentOS-7-x86_64/RPMS.chef/chef-14.7.17-1.el7.x86_64.rpm
         to file /tmp/kitchen/chef-14.7.17-1.el7.x86_64.rpm
       trying curl...
       Installing chef 14.7.17
       installing with rpm...

Actual Result:

       Download URL override specified
       /tmp/kitchen/ not found
       downloading http://<internal repo url>/opscode-CentOS-7-x86_64/RPMS.chef/chef-14.7.17-1.el7.x86_64.rpm
         to file /tmp/kitchen/
       trying curl...
       /tmp/kitchen/chef-installer.sh: ligne139: /tmp/kitchen/: est un dossier
       trying perl...
       /tmp/kitchen/chef-installer.sh: ligne169: /tmp/kitchen/: est un dossier
       grep: /tmp/kitchen/stderr: Aucun fichier ou dossier de ce type
       trying python...
       /tmp/kitchen/chef-installer.sh: ligne190: /tmp/kitchen/: est un dossier
       grep: /tmp/kitchen/stderr: Aucun fichier ou dossier de ce type
       Unable to retrieve a valid package!
       Version: 14.7.17

You can see /tmp/kitchen/ not found and to file /tmp/kitchen/, the package name is expected at the end of path, but it has been stripped.

I have been able to pin this down to #358 , it is old, but it seems this gem was not released for while, so this change was not released when it was merged.

@jeremy-clerc jeremy-clerc added Status: Untriaged An issue that has yet to be triaged. Type: Bug Does not work as expected. labels Aug 13, 2021
@jeremy-clerc jeremy-clerc changed the title fetch_package.sh strips too much of the filename fetch_package.sh filename incorrectly extracted Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Untriaged An issue that has yet to be triaged. Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant