Unset/reset SVDIR inside chef-server-ctl

[docwhat]

chef-server-ctl (and any other -ctl programs) should unset or override the SVDIR environment variable.

I customize the environment variable SVDIR on all my cheffed servers, which broke chef-server-ctl:

$ chef-server-ctl status
fail: bookshelf: unable to change to service directory: file does not exist
fail: nginx: unable to change to service directory: file does not exist
fail: oc_bifrost: unable to change to service directory: file does not exist
fail: oc_id: unable to change to service directory: file does not exist
fail: opscode-erchef: unable to change to service directory: file does not exist
fail: opscode-expander: unable to change to service directory: file does not exist
fail: opscode-expander-reindexer: unable to change to service directory: file does not exist
fail: opscode-pushy-server: unable to change to service directory: file does not exist
fail: opscode-reporting: unable to change to service directory: file does not exist
fail: opscode-solr4: unable to change to service directory: file does not exist
fail: postgresql: unable to change to service directory: file does not exist
fail: rabbitmq: unable to change to service directory: file does not exist
fail: redis_lb: unable to change to service directory: file does not exist

It also breaks reconfigure as well. :-(

[stevendanna]

Thanks for filing this bug. Unsetting SVDIR at the start of chef-server-ctl definitely seems like the best course of action here. We should probably do that in omnibus-ctl directly if possible.

[srenatus]

Merged in omnibus-ctl -- this will be pulled into the next release, so I'm closing this. 😃