refactor: Use the parser's DOM without modifications #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING: This removes the `root` property from root nodes. Instead, the `root` reference is kept in the (previously `null`) `parent` property. Also bumps `css-select`, as the new version includes a fix for `parent` references that aren't elements.
fb55
commented
Dec 11, 2020
| @@ -182,7 +182,6 @@ The options in the `xml` object are taken directly from [htmlparser2](https://gi | |||
|
|
|||
| ```js | |||
| { | |||
| withDomLvl1: true, | |||
There was a problem hiding this comment.
This option no longer exists in htmlparser2.
fb55
commented
Dec 11, 2020
| @@ -33,7 +33,7 @@ describe('cheerio', function () { | |||
| var $ = cheerio.load('<div>a div</div><span>a span</span>'); | |||
| var $collection = $('div').add($.root()).add('span'); | |||
| var expected = | |||
| '<span>a span</span><html><head></head><body><div>a div</div><span>a span</span></body></html><div>a div</div>'; | |||
There was a problem hiding this comment.
These elements used to be disjoint, because uniqueSort did not resolve the root reference. Now, uniqueSort will actually put the document first & the span last (as it should).
|
If root element is removed does parse5 htmlparser2 tree-adapter also needs to change ?? So it wont generate root node ? |
|
Both parsers produce root nodes. This change prevents cheerio from taking away the existing root nodes and replacing them with a custom one. Updating the description above as I can see where the confusion comes from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: This removes the
rootproperty from top-level nodes. Instead, therootreference is kept in the (previouslynull)parentproperty. Cheerio now uses the root object generated by either of the parsers.Also bumps
css-select, as the new version includes a fix forparentreferences that aren't elements.