find() convert xlink:href to href

[exitudio]

cheerio@^1.0.0-rc.2 automatically converts xlink:href to href when using find().

cheerio.load('')('<span><svg ><use xlink:href="#1" /></svg></span>').find('use').prop('xlink:href') //undefined
cheerio.load('')('<span><svg ><use xlink:href="#1" /></svg></span>').find('use').prop('href') //#1

Since, Safari doesn't support href without the "xlink" prefix in svg yet. Maybe, leave xlink:href as it was in cheerio@^0.22.0 is better?

[peter-mouland]

some background to this issue: enzymejs/enzyme#1297 (comment)

[fb55]

We're using parse5 for parsing, this seems to be an issue with its svg implementation. cc'ing @inikulin

[inikulin]

parse5 parses xlink:href in SVG namespace as a namespaced attribute (as per spec). So, such an attribute is parsed as an attribute with the name href and xlink prefix. Cheerio uses htmlparser2 tree adapter and since original htmlparser2 hasn't concept of namespaced attributes, attribute prefixes are stored in parse5-specific x-attribsPrefix map on element:

(Interactive playground: https://runkit.com/inikulin/5a417be9053db70012a5954e)

It seems like Cheerio needs some additional work to support namespaced attributes in parse5 AST.

[fb55]

Kk, so this is a dom-serializer shot-coming. What was the reasoning why we didn't use parse5 as a serialiser?

[kokers]

Is this something that will have a fix in some near future?

[fb55]

The serialization part should be fixed with the latest release.

[ljharb]

@fb55 thanks, confirmed fixed in rc 5 in enzyme's tests!

[ljharb]

@fb55 hmm, the tests passed locally but are failing in CI in node 4: https://travis-ci.com/github/enzymejs/enzyme/builds/210326410

Specifically, parse5-htmlparser2-tree-adapter is using object destructuring syntax, which means including it is a breaking change :-/

[ljharb]

Filed #1585 for this.