Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to checkstyle 7.6 #81

Closed
romani opened this issue Feb 26, 2017 · 4 comments
Closed

upgrade to checkstyle 7.6 #81

romani opened this issue Feb 26, 2017 · 4 comments
Assignees
@romani
Labels
approved
Milestone
3.6

Comments

@romani
Copy link
Member

romani commented Feb 26, 2017 •
edited
Loading

after release of checkstyle 7.6

http://checkstyle.sourceforge.net/releasenotes.html#Release_7.6 ,

upgrade version at https://github.com/checkstyle/sonar-checkstyle/edit/master/pom.xml#L88

Summary:
WhitespaceAroundCheck - new option
NoWhitespaceBefore - new token type
NPathComplexityCheck - !!! removal of option for Sonar !!!. Need to be retested with existing rule in 7.5 and upgrade to 7.6
romani added a commit that referenced this issue Feb 27, 2017
@romani
Issue #81: upgrade to checkstyle 7.6
1862ce2
@romani romani self-assigned this Feb 27, 2017
@romani
Copy link
Member Author

romani commented Feb 27, 2017 •
edited
Loading

In existing Rules new options and new token values(even default) are not shown in UI - to get access to new options and tokens values user need to create new Rule from template.

Default tokens are stored explicitly in Sonar DB config so they will not be applied automatically.

@romani
Copy link
Member Author

romani commented Feb 27, 2017

WhitespaceAroundCheck and NoWhitespaceBefore are passed testing. Works ok.

@romani
Copy link
Member Author

romani commented Feb 27, 2017

NPathComplexityCheck - works fine.
If user had rule active, he need to recreate it. If still a problem, token property need to be set manually in DB tables to default values.

@romani
Copy link
Member Author

romani commented Feb 27, 2017

fix is merged.

@romani romani closed this as completed Feb 27, 2017
@romani romani added this to the 3.6 milestone Feb 27, 2017
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani @tsjensen
Issue checkstyle#81: upgrade to checkstyle 7.6
fa34aea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romani romani

Labels
approved
Projects
None yet
Milestone
3.6
Development

No branches or pull requests
1 participant
@romani