Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

after 8.36 update we missing validation on basic types #322

Closed
romani opened this issue Aug 30, 2020 · 3 comments
Closed

after 8.36 update we missing validation on basic types #322

romani opened this issue Aug 30, 2020 · 3 comments
Labels
approved

Comments

@romani
Copy link
Member

romani commented Aug 30, 2020 •
edited
Loading

in code base after update to 8.36
create new rule for "Abbreviation As Word In Name" make any boolean value to be "1111"
Detected: no violation, config is saved
Expected: violation and dialog window should not allow to save config.

Attention in PR please test all other basic types and share screenshots with violations. Please also test regexp.

in 8.33 we did:
Screenshot from 2020-08-29 17-08-01
@romani romani mentioned this issue Aug 30, 2020
Merged
@gaurabdg gaurabdg mentioned this issue Aug 30, 2020
Merged
@romani
Copy link
Member Author

romani commented Aug 30, 2020

@gaurabdg ,
http://javadocs.sonarsource.org/latest/apidocs/org/sonar/api/server/rule/RuleParamType.html
Please add support of float , checkstyle do support it.
https://checkstyle.org/property_types.html
Please review other similar types.

@romani romani changed the title after 8.36 update we missing validation on boolean after 8.36 update we missing validation on basic types Aug 30, 2020
@gaurabdg gaurabdg mentioned this issue Aug 31, 2020
Merged
@muhlba91
Copy link
Contributor

muhlba91 commented Sep 1, 2020

@gaurabdg do we have a lead on the bool issue?

@muhlba91 muhlba91 mentioned this issue Sep 1, 2020
Closed
@muhlba91 muhlba91 mentioned this issue Sep 1, 2020
Closed
@gaurabdg
Copy link
Contributor

gaurabdg commented Sep 1, 2020

@gaurabdg do we have a lead on the bool issue?

It is merged #325.

@muhlba91 muhlba91 closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@muhlba91 @romani @gaurabdg