Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value of ParameterName accessModifiers is wrong #103

Closed
marschall opened this issue May 6, 2017 · 3 comments
Closed

Default value of ParameterName accessModifiers is wrong #103

marschall opened this issue May 6, 2017 · 3 comments
Labels
Milestone

Comments

@marschall
Copy link
Contributor

Sonar version: 5.6.5
Checkstyle sonar plugin verson: 3.6.1

Steps to reproduce or description of problem:

Create an SonarQube quality profile by importing the following Checkstyle configuration

<module name="Checker">
    <module name="TreeWalker">
        <module name="ParameterName"/>
    </module>
</module>

The import will fail because the default value of the accessModifiers property is public, protected, package, private (a space after each comma) but it should be public,protected,package,private (no space after each comma)

@romani
Copy link
Member

romani commented May 6, 2017

fix is merged.
There are more cases like this in code, I will try to make issue on it.
It would be good to make UT on this as config is too big to keep it in sync manually

@marschall
Copy link
Contributor Author

What is UT? Yes, ideally the rules.xml would be generated.

@romani
Copy link
Member

romani commented May 6, 2017

UT - unit test, we already have UT for it, but it is not ideal.

ideally the rules.xml would be generated.

no arguing, but no people who can do this. Validation will be good even for generated file.
So we support it step by step.

@romani romani added this to the 3.7 milestone May 6, 2017
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants