Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how no squale parameters affect a Check in Sonar #101

Closed
romani opened this issue Apr 30, 2017 · 3 comments
Closed

Investigate how no squale parameters affect a Check in Sonar #101

romani opened this issue Apr 30, 2017 · 3 comments
Labels

Comments

@romani
Copy link
Member

romani commented Apr 30, 2017

  1. Whole test was ignored test(), it need to removed or make it work. IntelijIdea inspection is complaining about this Ignore annotation.

  2. We have list of Checks that are not having sqale parameters
    https://github.com/checkstyle/sonar-checkstyle/blob/master/checkstyle-sonar-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java#L34
    Not clear why such Checks are so special.

most issues were added as fix for build failure - https://github.com/checkstyle/sonar-checkstyle/blame/6b53207becaf77253a92a684e06c58b80317457f/checkstyle-sonar-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleRulesDefinitionTest.java

@romani
Copy link
Member Author

romani commented Apr 30, 2017

debtSubCharacteristic() is deprecated and always return null in api 5.6.6, so I removed its usage from UT.

https://github.com/SonarSource/sonarqube/blob/master/sonar-plugin-api/src/main/java/org/sonar/api/server/rule/RulesDefinition.java#L1014

@romani
Copy link
Member Author

romani commented Apr 30, 2017

point "1)" is fixed.

If smb have time to investigate/fix "2)" - please be welcome.

tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@muhlba91
Copy link
Contributor

related to #219 - closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants