Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass options from docker cli to criu #506

Closed
zhouxinyu opened this issue Jun 12, 2018 · 6 comments
Closed

Pass options from docker cli to criu #506

zhouxinyu opened this issue Jun 12, 2018 · 6 comments

Comments

@zhouxinyu
Copy link

Hi,

I am testing the docker checkpoint/restore feature based on Docker version 17.03.1-ce, I need pass some options from docker cli to criu, like --tcp-close when restore the docker, any solutions?

@adrianreber
Copy link
Member

Currently no solution. We recently continued the discussion how to handle configuration files for the RPC case: https://lists.openvz.org/pipermail/criu/2018-May/041211.html

As docker is using runc and runc is using CRIU via RPC, that would be the solution for you. I just need to find the time to rewrite the patches.

@zhouxinyu
Copy link
Author

Thanks @adrianreber , I inserted the options in cr_service.c#restore_using_req method as a workaround solution, looking forward to your official solution~

@adrianreber
Copy link
Member

Also see #278

@adrianreber
Copy link
Member

adrianreber commented Aug 2, 2018

Configuration file support in RPC mode has been merged into the development branch : d1439a6

@adrianreber
Copy link
Member

Available since CRIU 3.11. Needs opencontainers/runc#1933 to be merged. CRIU parts are finished though.

@hanwen-flow
Copy link

to answer the original request: options can be added in /etc/criu/runc.conf, and then docker will pick them up automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants