-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes and modest extensions #44
Comments
Comment from @dtarditi: Generally looks good - I've pointed out some minor nits in the code. The PersistentSourceLoc file needs more comments describing what it is doing. Please clarify that the source location used for comparisons is the original textual location, not the expanded source location. You might want a helper function for validating that a range can be rewritten. Currently, you are checking that a range is valid and that getRangeSize(...) != -1. The test that getRangeSize(...) != -1 is idiomatic, so using a helper function would make the code clearer to read. |
Comment from @awruef: I think I've addressed the code review feedback. |
Comment from @dtarditi: LGTM. |
This issue was copied from checkedc/checkedc-clang#44
Many changes to deal with running on "real" code:
The text was updated successfully, but these errors were encountered: