Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse bounds declarations for function return values. #21

Closed
secure-sw-dev-bot opened this issue Jan 16, 2022 · 3 comments
Closed

Parse bounds declarations for function return values. #21

secure-sw-dev-bot opened this issue Jan 16, 2022 · 3 comments

Comments

@secure-sw-dev-bot
Copy link

This issue was copied from checkedc/checkedc-clang#21


This extends parsing of function declarators to parse bounds expressions for
function return values. A return bounds expression is declared by following
a parameter list with ':' bounds-expression.

The return bounds information is propagated to the representation of function
declarations in clang. It is not propagated yet to function types because
there is no way to represent it in function types. I have opened issue #20
to track that and added a few TODO's to the code flagging where the
information will need to be added.

Testing:

  • Add feature tests for parsing return bounds. The tests are in
    the file return_bounds.c, which will be committed separately to the checkedc
    Github repo.
  • Passes existing clang regression test baseline.
@secure-sw-dev-bot
Copy link
Author

Comment from @msftclas:

Hi @dtarditi, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (David Tarditi). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@secure-sw-dev-bot
Copy link
Author

Comment from @reubeno:

I called out a few very low-priority suggestions; otherwise, looks great.

@secure-sw-dev-bot
Copy link
Author

Comment from @awruef:

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant