-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow the Checked C extension flag for C. #16
Comments
Comment from @msftclas: Hi @dtarditi, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Comment from @reubeno: Finished taking a pass over this; my main question is around the overhead to maintain the expected test counts for tests we add. Apart from that, this looks good. (And thanks for putting in the effort to add those test cases!) |
Comment from @dtarditi: I've updated the documentation so that we will not maintain expected passing test counts, which could add overhead. Instead we'll just make sure that there are no unexpected test failures. I addressed your other comments and updated the issue9 branch. One neat thing: we're now checking that clang-cl understands the -fcheckedc-extension flag when it is passed using the -Xclang option to clang-cl. |
This issue was copied from checkedc/checkedc-clang#16
This change only allows the -fcheckedc-extension flag to be used for C programs
in clang. The clang driver will reject the use of -fcheckedc-extension for
other C family languages supported by clang, including C++, Objective
C, OpenCL, and CUDA. This addresses issue #9 in the checked-clang Github repo.
We are currently not modifying clang to support these other languages, which
is why need to disallow using the extension with them.
Testing:
rejected for C++, Objective C, CUDA, and OpenCL.
other similar tests in the test tree.
the documentation to reflect the fact that we have Checked C specific tests
in clang. We need to take the new tests into account when updating to new
versions of the clang/LLVM sources.
The text was updated successfully, but these errors were encountered: