Skip to content

Commit

Permalink
[ADT] Remove MSVC-only "no two-phase name lookup" typename path.
Browse files Browse the repository at this point in the history
Now that we've dropped VS2015 support (D64326) we can use the regular codepath as VS2017+ correctly handles it

llvm-svn: 365502
  • Loading branch information
RKSimon committed Jul 9, 2019
1 parent e625eb9 commit d050e45
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions llvm/unittests/ADT/DenseMapTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -119,17 +119,8 @@ TYPED_TEST(DenseMapTest, EmptyIntMapTest) {
// Lookup tests
EXPECT_FALSE(this->Map.count(this->getKey()));
EXPECT_TRUE(this->Map.find(this->getKey()) == this->Map.end());
#if !defined(_MSC_VER) || defined(__clang__)
EXPECT_EQ(typename TypeParam::mapped_type(),
this->Map.lookup(this->getKey()));
#else
// MSVC, at least old versions, cannot parse the typename to disambiguate
// TypeParam::mapped_type as a type. However, because MSVC doesn't implement
// two-phase name lookup, it also doesn't require the typename. Deal with
// this mutual incompatibility through specialized code.
EXPECT_EQ(TypeParam::mapped_type(),
this->Map.lookup(this->getKey()));
#endif
}

// Constant map tests
Expand Down

0 comments on commit d050e45

Please sign in to comment.