Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Adding s390x support to che-cert-manager-ca-cert-generator-image #6

Closed
prabhav-thali opened this issue May 8, 2020 · 8 comments
Closed

Comments

@prabhav-thali
Copy link
Contributor

As quay.io supports multi-arch images, we would like to extend s390x support for CI. Could you please provide some info about the CI process?

@ericwill
Copy link

ericwill commented May 8, 2020

We are in the process of converting all plugin sidecars to multi-arch support, using docker buildx. I am currently working on a PR for che-sidecar-vale which will eventually be applied to all repos in che-dockerfiles.

@prabhav-thali
Copy link
Contributor Author

@ericwill That's Great! Please let us know if you need any assistance from our side, we can help to test on s390x architecture. Will keep this issue open till multi-arch images are available.

@prabhav-thali
Copy link
Contributor Author

@ericwill any update on adding multi-arch support using docker buildx?

@ericwill
Copy link

@ericwill any update on adding multi-arch support using docker buildx?

It's an ongoing process. Are you looking for any repos specifically (i.e. this one)?

@ericwill
Copy link

Looking at this again, the use-case is a bit different than our plugin sidecar repos. I think in this instance @mmorhun might be able to help you.

@mmorhun
Copy link
Contributor

mmorhun commented Jul 13, 2020

I think that the support for building on s390x architecture was added in #5. As about pushing built image to quay.io I am afraid I cannot help here as, AFAIK, CentOS CI doesn't have s390x nodes (and I have no admin rights there).

@prabhav-thali
Copy link
Contributor Author

@ericwill @mmorhun Thanks for providing clarity. We have already started raising PRs in various repositories of Eclipse Che for instance #109 for che-machine-exec. We are adding support for s390x in CICO scripts using docker buildx. Should we proceed the same way for che-cert-manager-ca-cert-generator-image?

@mmorhun
Copy link
Contributor

mmorhun commented Jul 14, 2020

I don't think that this image is different from others. But I don't see (maybe I just don't know something) how we can build s390x images on our CI (build process requires hardware).
As about the image itself, it is used with Helm installer only. So if you use operator/olm installer, you may just skip it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants