Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of webpacker 5.1 #45

Merged
merged 2 commits into from
May 9, 2020
Merged

Migration of webpacker 5.1 #45

merged 2 commits into from
May 9, 2020

Conversation

kamontia
Copy link
Collaborator

@kamontia kamontia commented May 9, 2020

HERE is the information to resolve #44 issue.

It seems to be necessary to switch from ts-loader to babel as typescript loader due to the version up of webpacker.

close #44

@kamontia
Copy link
Collaborator Author

kamontia commented May 9, 2020

rm -rf node_modules && make build & make

image

@kamontia kamontia changed the title WIP: Migration of webpacker 5.1 Migration of webpacker 5.1 May 9, 2020
@kamontia
Copy link
Collaborator Author

kamontia commented May 9, 2020

@chaspy Please review and merge

Copy link
Owner

@chaspy chaspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chaspy chaspy merged commit 33da6c0 into master May 9, 2020
@chaspy chaspy deleted the Migration-of-Webpacker-5.1 branch May 9, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't be recognized as Typescript
2 participants