Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grace gets called twice for y axis, resulting in wrong y scale #8912

Closed
jsbrain opened this issue Apr 16, 2021 · 0 comments · Fixed by #8913
Closed

grace gets called twice for y axis, resulting in wrong y scale #8912

jsbrain opened this issue Apr 16, 2021 · 0 comments · Fixed by #8913
Labels
type: bug
Milestone
Version 3.1.1

Comments

@jsbrain
Copy link

jsbrain commented Apr 16, 2021

Expected Behavior

Applying grace: '100%' to y scale of +-10 should return in y scale of +-20

Current Behavior

_addGrace gets called twice with the second call receiving the result from the first call (recursive?!), resulting in an actual y scale of +-40. The bug doesn't seem to occur for x axis, at least for me.

Steps to Reproduce

https://codepen.io/jsbrain/pen/NWdBrZm

Environment

  • Chart.js version: 3.1.0
  • Browser name and version: all browsers
@jsbrain jsbrain changed the title Grace gets called twice for y axis, resulting in wrong y scale grace gets called twice for y axis, resulting in wrong y scale Apr 16, 2021
@kurkle kurkle mentioned this issue Apr 17, 2021
Merged
@kurkle kurkle added this to the Version 3.1.1 milestone Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.1.1
Development

Successfully merging a pull request may close this issue.

Scale: Make sure grace is applied only once kurkle/Chart.js
2 participants
@jsbrain @kurkle