Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Vertical gradient on line chart does not colour the points on 2.7.3 #5945

Closed
avidenov opened this issue Dec 31, 2018 · 3 comments
Closed

Comments

@avidenov
Copy link

avidenov commented Dec 31, 2018

I've discovered an issue when trying to apply a vertical gradient to a line chart.

screen shot 2018-12-31 at 13 37 53

Expected Behavior

The gradient should colour both the line and the points with the same gradient shades on both charts.

Current Behavior

The chart with the vertical gradient does not have the points coloured with the gradient shades, but with the first gradient colour.

Possible Solution

As a workaround I've set the colours manually for each point, based on the value, but this is not so linear and it is not a solution to the issue.

Steps to Reproduce (for bugs)

The CodePen example illustrates the issue.

Environment

  • Chart.js version: 2.7.3 (The issue does not appear on 2.7.2)
  • Browser name and version: Chrome Version 71.0.3578.98
@etimberg
Copy link
Member

I believe this is already fixed in master. I think it was fixed by @nagix in #5858

@benmccann
Copy link
Contributor

@avidenov you can check the latest master with:

git clone [email protected]:chartjs/Chart.js.git
cd Chart.js
npm install
gulp build

Then use the files in the dist/ directory

I'm going to close this for now as we believe it has already been fixed, but please let us know if that's not the case. Thanks!

@avidenov
Copy link
Author

avidenov commented Jan 1, 2019

@etimberg , @benmccann thanks, I can confirm that the issue is fixed when using the master branch build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants