[BUG] Logarithmic Charts infinite tick marks

[dak]

Expected Behavior

Browser shouldn't crash when loading logarithmic chart.

Current Behavior

Browser crashes when attempting to load a logarithmic chart (probably due to a 0 data point).

Possible Solution

The error appears to occur in core.ticks.js in the do-while loop on line 125. exp is being set to -Infinity because helpers.log10(0) (correctly) returns -Infinity. The loop then becomes infinite because of the check exp < endExp (line 135) — -Infinity + 1 is still -Infinity, and so -Infinity is always less than some integer.

Therefore, modifying line 135 to add a isFinite(exp) check would fix the issue:

while (isFinite(exp) && (exp < endExp || (exp === endExp && significand < endSignificand))));

Environment

• Chart.js version: 2.7.0
• Browser name and version: All browsers (Chrome 61, Safari 11, Firefox 52 ESR used for testing)

[etimberg]

Closing as duplicate of #4572