Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale Documentation issues #2894

Closed
moberwasserlechner opened this issue Jul 1, 2016 · 3 comments
Closed

Scale Documentation issues #2894

moberwasserlechner opened this issue Jul 1, 2016 · 3 comments

Comments

@moberwasserlechner
Copy link
Contributor

moberwasserlechner commented Jul 1, 2016

Scanning through your docs I found a few documentation issues:

Common configuration
The Option "id" is not documented at all. Although it's used in various samples like line-multi-axis.htm

Category scale options
Option "gridLines.offsetGridLines" is redundant because it's already defined in the common configuration.

Linear scale options
Option "stepSize" is defined twice. The first one should be fixedStepSize.

BR,
Michael

@moberwasserlechner
Copy link
Contributor Author

If I remove the redundant "offsetGridLines" from the docs, should I use its description in the common configuration?

If true, offset labels from grid lines.

vs

If true, labels are shifted to be between grid lines. This is used in the bar chart.

The 2nd seems to be more precise.

@etimberg
Copy link
Member

etimberg commented Jul 2, 2016

@moberwasserlechner I agree that the second is more precise and should be used

@etimberg
Copy link
Member

Fixed in #2901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants