Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radar charts do not look good when all datasets are hidden #2602

Closed
panzarino opened this issue May 19, 2016 · 6 comments
Closed

Radar charts do not look good when all datasets are hidden #2602

panzarino opened this issue May 19, 2016 · 6 comments

Comments

@panzarino
Copy link
Contributor

Radar charts change to scales that include extremely long decimals which really do not look good when all datasets are disabled through the legend. For example, try disabling the two datasets on this chart in the documentation: http://www.chartjs.org/docs/#radar-chart-introduction.

@etimberg
Copy link
Member

This is a string formatting mixed with javascript number problem. Not sure what the best course of action is in this case

@panzarino
Copy link
Contributor Author

Round to a single decimal point?

@etimberg
Copy link
Member

works in this case. Maybe the radialLinear scale should use the same function as the linear scale. https://github.com/chartjs/Chart.js/blob/master/src/scales/scale.linear.js#L10-L33

Essentially it tries to determine the correct number of data places dynamically.

@jewkesy
Copy link

jewkesy commented May 21, 2016

Any idea why the scale would default back to -1 to 1, rather than maintain the data scale of 0 to 100 as in the example?

@etimberg
Copy link
Member

@jewkesy I don't remember why [-1, 1] was chosen. I am fine with changing it

@jewkesy
Copy link

jewkesy commented May 25, 2016

@etimberg The more I think about it, the more I think it is worth keeping [-1, 1].

Assuming that it is possible to change the data while hidden, I wouldn't want to see a fluctuating scale on an empty chart.

Also when the charts are scaled down on mobile devices, the scale is more legible when using a single digit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants