From 7cd0583487cd9573270d2dc0c1700a6839ac1601 Mon Sep 17 00:00:00 2001 From: Ayman Bagabas Date: Thu, 13 Jul 2023 14:06:05 -0400 Subject: [PATCH] fix(ci): golangci linter Add soft lint --- .github/workflows/lint-soft.yml | 28 ++++++++++++++++++++ .github/workflows/lint.yml | 13 ++++++--- .golangci-soft.yml | 47 +++++++++++++++++++++++++++++++++ .golangci.yml | 10 +++---- 4 files changed, 88 insertions(+), 10 deletions(-) create mode 100644 .github/workflows/lint-soft.yml create mode 100644 .golangci-soft.yml diff --git a/.github/workflows/lint-soft.yml b/.github/workflows/lint-soft.yml new file mode 100644 index 000000000..623052892 --- /dev/null +++ b/.github/workflows/lint-soft.yml @@ -0,0 +1,28 @@ +name: lint-soft +on: + push: + pull_request: + +permissions: + contents: read + # Optional: allow read access to pull request. Use with `only-new-issues` option. + pull-requests: read + +jobs: + golangci: + name: lint-soft + runs-on: ubuntu-latest + steps: + - name: Install Go + uses: actions/setup-go@v4 + with: + go-version: ^1 + + - uses: actions/checkout@v3 + - name: golangci-lint + uses: golangci/golangci-lint-action@v3 + with: + # Optional: golangci-lint command line arguments. + args: --config .golangci-soft.yml --issues-exit-code=0 + # Optional: show only new issues if it's a pull request. The default value is `false`. + only-new-issues: true diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 5e96efe53..2f26b2ac2 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -3,19 +3,26 @@ on: push: pull_request: +permissions: + contents: read + # Optional: allow read access to pull request. Use with `only-new-issues` option. + pull-requests: read + jobs: golangci: name: lint runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-go@v4 + - name: Install Go + uses: actions/setup-go@v4 with: go-version: ^1 + + - uses: actions/checkout@v3 - name: golangci-lint uses: golangci/golangci-lint-action@v3 with: # Optional: golangci-lint command line arguments. - args: --issues-exit-code=0 + #args: # Optional: show only new issues if it's a pull request. The default value is `false`. only-new-issues: true diff --git a/.golangci-soft.yml b/.golangci-soft.yml new file mode 100644 index 000000000..ef456e060 --- /dev/null +++ b/.golangci-soft.yml @@ -0,0 +1,47 @@ +run: + tests: false + +issues: + include: + - EXC0001 + - EXC0005 + - EXC0011 + - EXC0012 + - EXC0013 + + max-issues-per-linter: 0 + max-same-issues: 0 + +linters: + enable: + # - dupl + - exhaustive + # - exhaustivestruct + - goconst + - godot + - godox + - gomnd + - gomoddirectives + - goprintffuncname + - ifshort + # - lll + - misspell + - nakedret + - nestif + - noctx + - nolintlint + - prealloc + - wrapcheck + + # disable default linters, they are already enabled in .golangci.yml + disable: + - deadcode + - errcheck + - gosimple + - govet + - ineffassign + - staticcheck + - structcheck + - typecheck + - unused + - varcheck diff --git a/.golangci.yml b/.golangci.yml index 2be31f224..a5a91d0d9 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -15,19 +15,15 @@ issues: linters: enable: - bodyclose - - dupl - exportloopref - - goconst - - godot - - godox - goimports - - goprintffuncname - gosec - - misspell - - prealloc + - nilerr + - predeclared - revive - rowserrcheck - sqlclosecheck + - tparallel - unconvert - unparam - whitespace