Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IgnoreEmpty in YamlConfiguration #284

Closed
DasLixou opened this issue May 13, 2022 · 4 comments
Closed

Add IgnoreEmpty in YamlConfiguration #284

DasLixou opened this issue May 13, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@DasLixou
Copy link

Describe the problem you'd like to solve

Hello! I want to have defaults so that when a property is missing it just gets the default of the kotlin data class. Only problem: Kaml throws an Exception in thread "main" com.charleskorn.kaml.EmptyYamlDocumentException at <root> on line 1, column 1: The YAML document is empty. Error, because the file is empty.

Describe the solution you'd like

Add a IgnoreEmpty boolean in YamlConfiguration so it doesnt throw an EmptyYamlDocumentException

Describe alternatives you've considered

No response

Additional context

No response
@charleskorn
Copy link
Owner

Seems sensible to me - would you be open to putting together a PR for this?

@charleskorn charleskorn added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 13, 2022
@charleskorn
Copy link
Owner

(for anyone else coming across this issue: for further context, see #281 (reply in thread))

@DasLixou
Copy link
Author

Seems sensible to me - would you be open to putting together a PR for this?

Sure I’ll try my best :)

@DasLixou DasLixou mentioned this issue May 15, 2022
Closed
@charleskorn
Copy link
Owner

Given the issues discussed in #286, I'm going to close this as "won't fix".

@charleskorn charleskorn closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charleskorn @DasLixou